Thread (48 messages) 48 messages, 7 authors, 2004-07-26

Re: [PATCH] fix missing option in binutils version check

From: Tom Rini <hidden>
Date: 2004-07-15 14:15:40

On Thu, Jul 15, 2004 at 02:50:32PM +0200, Olaf Hering wrote:
 On Wed, Jul 14, Tom Rini wrote:

quoted
+BAD_GCC_AS	:= $(shell echo mftb 5 | $(AS) -mppc -many -o /dev/null 2>/dev/null 2>&1 && echo 0 || echo 1)

-ifneq ($(NEW_AS),0)
 checkbin:
+ifeq ($(GCC_VERSION)$(BAD_GCC_AS),03041)
How is this supposed to work? You get either 0 or 1.
OK.  The intent was that GCC_VERSION is always run, which will give
'0304' on gcc-3.4 (tested) and if the binutils test also fails it will
always give '1'.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help