Re: [PATCH] fix missing option in binutils version check
From: Tom Rini <hidden>
Date: 2004-07-04 02:41:49
On Sun, Jul 04, 2004 at 03:30:47AM +0200, Stef Simoens wrote:
Olaf Hering wrote:quoted
On Tue, Jun 15, Tom Rini wrote:quoted
And yes, passing -many does work on all older supported versions of binutils. So perhaps we should just add -Wa,-many to our cflags and be done with it now (and for future fixes of this sort).gcc 3.2 passes only -mppc, so all altive instructions will fail to compile without either -many or -maltivecAre there altivec instructions when CONFIG_ALTIVEC is not set?
Yes. And I can forsee in the future were we might have BookE specific ones in the same situation.
quoted
ifdef CONFIG_4xx EXTRA_AFLAGS := -Wa,-m405 endif +ifdef CONFIG_6xx +EXTRA_AFLAGS := -Wa,-maltivec +endif ifdef CONFIG_E500 EXTRA_AFLAGS := -Wa,-me500 endifSo, shouldn't this be "ifdef CONFIG_ALTIVEC" ?
No, it should be always -Wa,-many. The kernel has, and almost certainly will, continue to put AltiVec, or BookE, or whatever, instructions in code that will be compiled for, and run on, CPUs that can't use the instructions (we nop them out at runtime). -- Tom Rini http://gate.crashing.org/~trini/ ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/