Re: [PATCH 6/7] tools/rtla: Add test engine support for unexpected output
From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-09-03 16:15:49
út 2. 9. 2025 v 21:08 odesílatel Crystal Wood [off-list ref] napsal:
It would be nice to not depend on an out-of-tree test harness (does anything else in the kernel use this?), especially without a prominent comment mentioning it. I've just been doing "sudo sh tests/whatever.t".
Ah, I see, I should document the tests properly, I'll send a patch. To clarify, "make check" uses Test::Harness on the RTLA tests. It's an external tool but it seems it is usually installed on RHEL/Fedora so I went with it.
Ugh, "prove" looks like it's some sort of formal rv thing... misleading name for just running a test suite.
Yeah not exactly a good name, I always forget how it is named...
It already does print the test name. If it didn't I probably would have made more substantial changes to the test harness :-)
Test::Harness only displays it in verbose mode which is not enabled, since I thought it doesn't look as nice, I was maybe wrong.
quoted
Yes, this is used by kselftests [2], which are written in C. [2] https://docs.kernel.org/dev-tools/kselftest.htmlWould it make sense for us to use that? Though the current docs linking to a wiki that's labelled "obsolete content" isn't encouraging...
I don't think we need it or it would help us. The RTLA test engine in bash is good enough IMO and customizable. Tomas