Re: [PATCH 1/7] tools/rtla: Consolidate common parameters into shared structure
From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-08-26 14:16:09
From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-08-26 14:16:09
čt 21. 8. 2025 v 5:58 odesílatel Crystal Wood [off-list ref] napsal:
From: Costa Shulyupin <redacted> timerlat_params and osnoise_params structures contain 15 identical fields. Introduce a new header common.h and define a common_params structure to consolidate shared fields, reduce code duplication, and enhance maintainability. Signed-off-by: Costa Shulyupin <redacted> Signed-off-by: Crystal Wood <redacted>
There is an idea in the osnoise tracer that timerlat is somehow its extension, for example, it uses struct osnoise_options for some of its settings. But osnoise is a distinct tracer from timerlat, and this mostly creates confusion and IMHO we should clearly separate them from now on. Reviewed-by: Tomas Glozar <tglozar@redhat.com> Tomas