Re: [PATCH 7/7] tools/rtla: Add remaining support for osnoise actions
From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-08-28 10:57:52
čt 21. 8. 2025 v 5:58 odesílatel Crystal Wood [off-list ref] napsal:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/tools/rtla/common_osnoise_options.rst b/Documentation/tools/rtla/common_osnoise_options.rst index d73de2d58f5f..ba8e6674c220 100644 --- a/Documentation/tools/rtla/common_osnoise_options.rst +++ b/Documentation/tools/rtla/common_osnoise_options.rst@@ -1,3 +1,11 @@ +.. |threshold| replace:: **-a/--auto**, **-s/--stop**, or **-S/--stop-total** +.. |thresharg| replace:: -s +.. |tracer| replace:: osnoise + +.. |actionsperf| replace:: + For time-sensitive actions, it is recommended to run **rtla** with + RT priority. +
Unfortunately, real-time priority won't really help you in practice for overflow-to-action latency, since the detection whether tracing was stopped is only done once per second, when pulling the data. The message should be instead just (something like): "Due to implementational limitations,actions might be delayed up to one second after tracing is stopped." until either a trace event is implemented for stop tracing threshold overflow (proposed in [1]), or rtla-osnoise is moved to BPF sample collection, too. [1] https://lore.kernel.org/linux-trace-kernel/CAP4=nvQWCWAOefHAqA82-VDb-00_y1-0fPOPBEyETJ2Q1EWEwg@mail.gmail.com/ (local)
quoted hunk ↗ jump to hunk
--- a/tools/tracing/rtla/tests/osnoise.t +++ b/tools/tracing/rtla/tests/osnoise.t@@ -8,7 +8,8 @@ set_timeout 2m check "verify help page" \ "osnoise --help" 0 "osnoise version" check "verify the --priority/-P param" \ - "osnoise top -P F:1 -c 0 -r 900000 -d 10s -q" + "osnoise top -P F:1 -c 0 -r 900000 -d 10s -q -S 1 --on-threshold shell,command=\"tests/scripts/check-priority.sh osnoise/ SCHED_FIFO 1\"" \ + 2 "Priorities are set correctly" check "verify the --stop/-s param" \ "osnoise top -s 30 -T 1" 2 "rtla hit stop tracing" check "verify the --trace param" \@@ -22,4 +23,28 @@ check "verify the --entries/-E param" \ check_with_osnoise_options "apply default period" \ "osnoise hist -s 1" 2 period_us=600000000
This is useful to have also for rtla-osnoise, thank you! Tomas