Thread (27 messages) 27 messages, 3 authors, 2025-09-03

Re: [PATCH 6/7] tools/rtla: Add test engine support for unexpected output

From: Tomas Glozar <tglozar@redhat.com>
Date: 2025-08-28 08:09:23

čt 21. 8. 2025 v 5:58 odesílatel Crystal Wood [off-list ref] napsal:
Simplify the code so that we can print failures as they happen rather
than trying to figure out what went wrong after printing "not ok".  This
also means that "not ok" gets printed after the info rather than before,
which seems more intuitive anyway.
This change is causing some formatting issues, e.g.:

tests/hwnoise.t ... 2/6 # Output match failed: "rtla hit stop tracing"
# Error iterating on events
# Oops, error disabling tracer
#
# exit code 1
tests/hwnoise.t ... 3/6 not ok 3 - set the automatic trace mode

(the comment is on the same line as the previous test)

Furthermore, it's standard to first print "not ok" and then the
comments, see the documentation to Test::More [1], so I think we
should keep that.

[1] https://metacpan.org/pod/Test::More#ok

Tomas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help