Thread (71 messages) 71 messages, 8 authors, 2019-03-07

Re: [PATCH v2 10/20] x86: avoid W^X being broken during modules loading

From: Nadav Amit <hidden>
Date: 2019-02-11 20:32:47
Also in: linux-integrity, linux-mm, lkml

On Feb 11, 2019, at 11:42 AM, Borislav Petkov [off-list ref] wrote:

On Mon, Feb 11, 2019 at 11:27:03AM -0800, Nadav Amit wrote:
quoted
Is there any comment over static_cpu_has()? ;-)
Almost:

/*
* Static testing of CPU features.  Used the same as boot_cpu_has().
* These will statically patch the target code for additional
* performance.
*/
static __always_inline __pure bool _static_cpu_has(u16 bit)
Oh, I missed this comment.

BTW: the “__pure” attribute is useless when “__always_inline” is used.
Unless it is intended to be some sort of comment, of course.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help