-----Original Message-----
From: Martin Wilck [mailto:mwilck@suse.com] 
Subject: Re: [PATCH V3 07/25] smartpqi: update AIO Sub Page 0x02 support

On Thu, 2020-12-10 at 14:35 -0600, Don Brace wrote:

From: Kevin Barnett <redacted>

The specification for AIO Sub-Page (0x02) has changed slightly.
* bring the driver into conformance with the spec.


+static inline u32 pqi_aio_limit_to_bytes(__le16 *limit) {
+       u32 bytes;
+
+       bytes = get_unaligned_le16(limit);
+       if (bytes == 0)
+               bytes = ~0;
+       else
+               bytes *= 1024;
+
+       return bytes;
+}

Nice, but this function and it's callers belong into patch 06/25.

Don: 
      * Squashed smartpqi-update-AIO-Sub-Page-0x02-support
      * Moved formatting HUNK for pqi_scsi_dev_raid_map_data into
        smartpqi-refactor-aio-submission-code
      * Moved structure pqi_aio_r56_path_request formatting HUNKS into
        smartpqi-add-support-for-raid5-and-raid6-writes
      * Moved remaining formatting HUNKs into
        smartpqi-align-code-with-oob-driver

Thanks for all of your attention to detail,
Don

This should be changed in 06/25.

                goto error;
        }

Regards
Martin