Thread (85 messages) 85 messages, 6 authors, 2021-03-30

Re: [PATCH V3 17/25] smartpqi: change timing of release of QRM memory during OFA

From: Martin Wilck <hidden>
Date: 2021-01-08 00:15:10

On Thu, 2020-12-10 at 14:35 -0600, Don Brace wrote:
From: Kevin Barnett <redacted>

* Release QRM memory (OFA buffer) on OFA error conditions.
* Controller is left in a bad state which can cause a kernel panic
    upon reboot after an unsuccessful OFA.

Reviewed-by: Scott Benesh <redacted>
Reviewed-by: Scott Teel <redacted>
Signed-off-by: Kevin Barnett <redacted>
Signed-off-by: Don Brace <don.brace@microchip.com>
I don't understand how the patch description relates to the actual
change. With the patch, the buffers are released just like before,
only some instructions later. So apparently, without this patch, the
OFA memory had been released prematurely?

Anyway,

Reviewed-by: Martin Wilck <redacted>


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help