Re: [RFC][PATCH v3] slub: Keep page and object in sync in slab_alloc_node()
From: Christoph Lameter <hidden>
Date: 2013-01-18 18:40:20
Also in:
linux-mm, lkml
On Fri, 18 Jan 2013, Steven Rostedt wrote:
quoted hunk ↗ jump to hunk
@@ -2337,7 +2337,10 @@ redo: * enabled. We may switch back and forth between cpus while * reading from one cpu area. That does not matter as long * as we end up on the original cpu again when doing the cmpxchg. + * + * But we need to sync the setting of page and object. */ + preempt_disable(); c = __this_cpu_ptr(s->cpu_slab); /*@@ -2347,10 +2350,14 @@ redo: * linked list in between. */ tid = c->tid;
The fetching of the tid is the only critical thing here. If the tid is retrieved from the right cpu then the cmpxchg will fail if any changes occured to freelist or the page variable. The tid can be retrieved without disabling preemption through this_cpu_read().