Re: [RFC][PATCH] slub: Check for page NULL before doing the node_match check
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2013-01-17 22:07:29
Also in:
linux-mm, lkml
On Thu, 2013-01-17 at 21:51 +0000, Christoph Lameter wrote:
Ditto which leaves us with:
Except...
quoted hunk ↗ jump to hunk
Index: linux/mm/slub.c ===================================================================--- linux.orig/mm/slub.c 2013-01-17 15:49:57.417491975 -0600 +++ linux/mm/slub.c 2013-01-17 15:50:49.010287150 -0600@@ -1993,8 +1993,9 @@ static inline void flush_slab(struct kme deactivate_slab(s, c->page, c->freelist); c->tid = next_tid(c->tid); - c->page = NULL; c->freelist = NULL;
+ /* + * Preemption may be enabled here, and if the task is preempted + * other tasks require that freelist is NULL if page is NULL. + */
+ barrier(); + c->page = NULL; } /*
-- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>