Re: [RFC][PATCH] slub: Check for page NULL before doing the node_match check
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2013-01-17 18:37:48
Also in:
linux-mm, lkml
On Thu, 2013-01-17 at 13:10 -0500, Steven Rostedt wrote:
quoted hunk ↗ jump to hunk
diff --git a/mm/slub.c b/mm/slub.c index 2d9511a..85b95d5 100644 --- a/mm/slub.c +++ b/mm/slub.c@@ -2399,7 +2399,7 @@ redo: object = c->freelist; page = c->page; - if (unlikely(!object || !node_match(page, node))) + if (unlikely(!object || !page || !node_match(page, node)))
I'm still trying to see if c->freelist != NULL and c->page == NULL isn't a bug. The cmpxchg_doubles are a little confusing. If it's not expected that page is NULL but freelist isn't than we need to figure out why it happened. -- Steve
object = __slab_alloc(s, gfpflags, node, addr, c);
else {
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>