Thread (32 messages) 32 messages, 4 authors, 2013-01-21

Re: [RFC][PATCH] slub: Keep page and object in sync in slab_alloc_node()

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2013-01-18 00:23:23
Also in: linux-mm, lkml

On Thu, 2013-01-17 at 18:20 -0500, Steven Rostedt wrote:
	object = c->freelist;
 	page = c->page;
Hmm, having local_irq_restore() here is probably just as good, as object
and page were grabbed together under it. It doesn't change the condition
below any.

/me updates patch.

-- Steve
-	if (unlikely(!object || !node_match(page, node)))
+
+	new_object = !object || !node_match(page, node);
+	local_irq_restore(flags);
+
+	if (new_object)
 		object = __slab_alloc(s, gfpflags, node, addr, c);
 
 	else {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help