Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq
From: Thomas Richard <thomas.richard@bootlin.com>
Date: 2024-02-08 16:19:35
Also in:
linux-arm-kernel, linux-gpio, linux-i2c, linux-omap, linux-pci, lkml
On 1/28/24 01:12, Linus Walleij wrote:
On Fri, Jan 19, 2024 at 6:01 PM Thomas Richard [off-list ref] wrote:quoted
On 1/16/24 08:43, Tony Lindgren wrote:quoted
* Thomas Richard [off-list ref] [240115 16:16]:quoted
Some IOs can be needed during suspend_noirq/resume_noirq. So move suspend/resume callbacks to noirq.So have you checked that the pca953x_save_context() and restore works this way? There's i2c traffic and regulators may sleep.. I wonder if you instead just need to leave gpio-pca953x enabled in some cases instead?Yes I tested it, and it works (with my setup). But this patch may have an impact for other people. How could I leave it enabled in some cases ?I guess you could define both pca953x_suspend() and pca953x_suspend_noirq() and selectively bail out on one path on some systems?
Yes. What do you think if I use a property like for example "ti,pm-noirq" to select the right path ? Is a property relevant for this use case ? Regards,
Worst case using if (of_machine_is_compatible("my,machine"))...
Yours,
Linus Walleij-- Thomas Richard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy