Re: [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback

On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
[off-list ref] wrote:

A device may need the controller up during suspend_noirq or
resume_noirq.
But if the controller is autosuspended, there is no way to wakeup it
during suspend_noirq or resume_noirq because runtime pm is disabled
at this time.

The suspend callback wakes up the controller, so it is available until
its suspend_noirq callback (pm_runtime_force_suspend).
During the resume, it's restored by resume_noirq callback
(pm_runtime_force_resume). Then resume callback enables autosuspend.

So the controller is up during a little time slot in suspend and resume
sequences even if it's not used.

Same comment

->...callback...()

...

 }

+

Stray blank line is added.

+static int omap_i2c_suspend(struct device *dev)

-- 
With Best Regards,
Andy Shevchenko

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy