RE: [PATCH v3 0/9] add the imx8m pcie phy driver and imx8mm pcie support

-----Original Message-----
From: Marcel Ziswiler <redacted>
Sent: Tuesday, October 26, 2021 11:57 PM
To: kishon@ti.com; vkoul@kernel.org; robh@kernel.org;
l.stach@pengutronix.de; shawnguo@kernel.org; tharvey@gateworks.com;
galak@kernel.crashing.org; Richard Zhu [off-list ref]
Cc: linux-phy@lists.infradead.org; linux-arm-kernel@lists.infradead.org;
kernel@pengutronix.de; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org; dl-linux-imx [off-list ref]
Subject: Re: [PATCH v3 0/9] add the imx8m pcie phy driver and imx8mm pcie
support

On Tue, 2021-10-12 at 16:41 +0800, Richard Zhu wrote:

quoted

refer to the discussion [1] when try to enable i.MX8MM PCIe support,
one standalone PCIe PHY driver should be seperated from i.MX PCIe
driver when enable i.MX8MM PCIe support.

This patch-set adds the standalone PCIe PHY driver suport[1-5], and
i.MX8MM PCIe support[6-9] to have whole view to review this patch-set.

The PCIe works on i.MX8MM EVK board based the the blkctrl power driver
[2] and this PHY driver patch-set.

Whole series:

Tested-by: Marcel Ziswiler <redacted>

BTW: I tested it on Verdin iMX8M Mini V1.1B without an external PCIe
oscillator aka setting fsl,refclk-pad-mode to
IMX8_PCIE_REFCLK_PAD_OUTPUT which worked like a charm. Thanks!

[Richard Zhu] Thanks for your tests.

Best Regards
Richard Zhu

quoted

[1]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc

hwork.ozlabs.org%2Fproject%2Flinux-pci%2Fpatch%2F20210510141509.929
120

quoted

-3-l.stach%40pengutronix.de%2F&data=04%7C01%7Chongxing.zhu%40
nxp.c

quoted

om%7Cbacb5db20f2d4aa7a4ad08d998993356%7C686ea1d3bc2b4c6fa92cd9
9c5c3016

quoted

35%7C0%7C0%7C637708606037565160%7CUnknown%7CTWFpbGZsb3d8ey
JWIjoiMC4wLj

quoted

AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp
;sdata=

quoted

Mmea0v4pP5VzSM%2F8sIStLkwvA0pY0h2lG4Vzvr8Gk%2F4%3D&reserv
ed=0

quoted

[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc

hwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Fcover%2F202109102026
40

quoted

.980366-1-l.stach%40pengutronix.de%2F&data=04%7C01%7Chongxin

g.zhu%

quoted

40nxp.com%7Cbacb5db20f2d4aa7a4ad08d998993356%7C686ea1d3bc2b4c6
fa92cd99

quoted

c5c301635%7C0%7C0%7C637708606037565160%7CUnknown%7CTWFpbGZ
sb3d8eyJWIjo

quoted

iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C10
00&amp

quoted

;sdata=5U%2BP0zL0OskhyB0RtH%2FsBwRn0B1Lb27ZSpjjhFD0wUo%3D&a

mp;reserved

quoted

=0

Main changes v2 --> v3:
- Regarding Lucas' comments.
 - to have a whole view to review the patches, send out the i.MX8MM

PCIe support too.

quoted

 - move the PHY related bits manipulations of the GPR/SRC to standalone

PHY driver.

quoted

 - split the dts changes to SOC and board DT, and use the enum instead of

raw value.

quoted

 - update the license of the dt-binding header file.

Changes v1 --> v2:
- Update the license of the dt-binding header file to make the license
  compatible with dts files.
- Fix the dt_binding_check errors.

Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |   6

+++

quoted

Documentation/devicetree/bindings/phy/fsl,imx8-pcie-phy.yaml |  79
+++++++++++++++++++++++++++++

arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi                |
53

quoted

++++++++++++++++++++

arch/arm64/boot/dts/freescale/imx8mm.dtsi

quoted

|  46 ++++++++++++++++-

drivers/pci/controller/dwc/pci-imx6.c

quoted

|  63 ++++++++++++++++++++++-

drivers/phy/freescale/Kconfig

quoted

|   9 ++++

drivers/phy/freescale/Makefile

quoted

|   1 +

drivers/phy/freescale/phy-fsl-imx8m-pcie.c                   |

quoted

218

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++

quoted

include/dt-bindings/phy/phy-imx8-pcie.h                      |
 14

quoted

++++++
9 files changed, 486 insertions(+), 3 deletions(-)

[PATCH v3 1/9] dt-bindings: phy: phy-imx8-pcie: Add binding for the
[PATCH v3 2/9] dt-bindings: phy: add imx8 pcie phy driver support
[PATCH v3 3/9] arm64: dts: imx8mm: add the pcie phy support [PATCH v3
4/9] arm64: dts: imx8mm-evk: add the pcie phy support [PATCH v3 5/9]
phy: freescale: pcie: initialize the imx8 pcie [PATCH v3 6/9]
dt-bindings: imx6q-pcie: Add PHY phandles and name [PATCH v3 7/9]
arm64: dts: imx8mm: add the pcie support [PATCH v3 8/9] arm64: dts:
imx8mm-evk: add the pcie support on imx8mm [PATCH v3 9/9] PCI: imx:
add the imx8mm pcie support

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy