Thread (89 messages) 89 messages, 4 authors, 2021-02-22

Re: [PATCH 08/35] monitor: add command line options to control logging

From: Martin Wilck <hidden>
Date: 2021-02-04 09:18:41

On Thu, 2021-02-04 at 08:04 +0100, Hannes Reinecke wrote:
On 1/26/21 9:32 PM, mwilck@suse.com wrote:
quoted
From: Martin Wilck <redacted>

Standard syslog loglevels are used.
Options:

  -S/--silent   to suppress LOG_NOTICE
  -v/--verbose  to enable LOG_INFO (overrides -S)
  -D/--debug    to enable LOG_DEBUG (overrides -S, -v)
  -C/--clockstamps to enable time stamps on log messages.

I tried to use short options that don't conflict with options
from nvme connect-all, because many of those options might be
useful for the monitor, too.

Signed-off-by: Martin Wilck <redacted>
---
  monitor.c | 47 +++++++++++++++++++++++++++++++++++++++++------
  1 file changed, 41 insertions(+), 6 deletions(-)
... and if you had moved the logging functionality prior to the
monitor 
code, this patch could be merged with the main monitor functionality,
too.
I expected that reviewers preferred smaller chunks. If that's not the
case, fine with me, I'll change i

Thanks,
Martin



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help