On Fri, 2021-01-29 at 12:16 -0800, Sagi Grimberg wrote:

quoted

quoted

quoted

With this option, "nvme monitor" will keep created discovery
controllers
running even after it exits. If running in the initrd, this is
will
be
done automatically. That has the advantage that the new monitor
instance
that will be started automatically after switching root can
simply
take
over the already created discovery controllers.

Why not make it the default?

Well, we've had a lot of discussions about persistent discovery
connections not being universally loved. So I thought I'd make
cleaning
up the default.

Heh... well, I didn't see thus far of any other good suggestion on
how
to propagate discovery change log events reliably (I've seen some bad
ones). And we are assuming that hosts need to know about these
changes...

The default matters here. The spec tells us how to learn about
change log events so I would suggest we follow it.

No problem, I can change this.

But I'm not quite following you here, because this option is about
keeping controllers up after the monitor exits. Given that the monitor
would be the instance that receives the AENs and acts upon them, what's
the point of keeping them alive after it has terminated?

Martin





_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme