Thread (89 messages) 89 messages, 4 authors, 2021-02-22

Re: [PATCH 13/35] monitor: disable nvmf-autoconnect udev rules in autoconnect mode

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2021-01-29 01:52:37


On 1/26/21 12:33 PM, mwilck@suse.com wrote:
From: Martin Wilck <redacted>

If autoconnect is enabled, disable the respective udev rules
by symlinking /run/udev/rules.d to /dev/null, in order to avoid
the connections being set up by the monitor and the udev workers
at the same time. This is probably the preferred mode of operation
for the monitor.

Users can override this by copying 70-nvmf-autoconnect.rules
from /usr/lib/udev/rules.d to /etc/udev/rules.d (/etc/udev/rules.d
takes precedence over /run/udev/rules.d).

If the symlink can't be created for some reason, autoconnect will
be disabled. There is  only one exception: If
/run/udev/rules.d/70-nvmf-autoconnect.rules already points to
/dev/null at startup, autoconnect can be left on, but the symlink
isn't removed on exit.
Can't we just document that just one should be enabled and skip
the entire thing? Especially when its not critical if both run..

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help