On Wed 24-03-21 15:52:38, David Hildenbrand wrote:

On 24.03.21 15:42, Michal Hocko wrote:

quoted

On Wed 24-03-21 13:03:29, Michal Hocko wrote:

quoted

On Wed 24-03-21 11:12:59, Oscar Salvador wrote:

[...]

quoted

quoted

I kind of understand to be reluctant to use vmemmap_pages terminology here, but
unfortunately we need to know about it.
We could rename nr_vmemmap_pages to offset_buddy_pages or something like that.

I am not convinced. It seems you are justr trying to graft the new
functionality in. But I still believe that {on,off}lining shouldn't care
about where their vmemmaps come from at all. It should be a
responsibility of the code which reserves that space to compansate for
accounting. Otherwise we will end up with a hard to maintain code
because expectations would be spread at way too many places. Not to
mention different pfns that the code should care about.

The below is a quick hack on top of this patch to illustrate my
thinking. I have dug out all the vmemmap pieces out of the
{on,off}lining and hooked all the accounting when the space is reserved.
This just compiles without any deeper look so there are likely some
minor problems but I haven't really encountered any major problems or
hacks to introduce into the code. The separation seems to be possible.
The diffstat also looks promising. Am I missing something fundamental in
this?

From a quick glimpse, this touches on two things discussed in the past:

1. If the underlying memory block is offline, all sections are offline. Zone
shrinking code will happily skip over the vmemmap pages and you can end up
with out-of-zone pages assigned to the zone. Can happen in corner cases.

You are right. But do we really care? Those pages should be of no
interest to anybody iterating through zones/nodes anyway.

There is no way to know that the memmap of these pages was initialized and
is of value.

2. You heavily fragment zone layout although you might end up with
consecutive zones (e.g., online all hotplugged memory movable)

What would be consequences?

-- 
Michal Hocko
SUSE Labs