Re: [PATCH v5 1/5] mm,memory_hotplug: Allocate memmap from the added memory range
From: Michal Hocko <mhocko@suse.com>
Date: 2021-03-24 12:11:51
Also in:
lkml
From: Michal Hocko <mhocko@suse.com>
Date: 2021-03-24 12:11:51
Also in:
lkml
On Wed 24-03-21 13:03:29, Michal Hocko wrote:
On Wed 24-03-21 11:12:59, Oscar Salvador wrote:
[...] an additional remark
quoted
- online_pages()->move_pfn_range_to_zone(): Accounts for node/zone's spanned pages - online_pages()->zone->present_pages += nr_pages;
I am pretty sure you shouldn't account vmmemmap pages to the target zone in some cases - e.g. vmemmap cannot be part of the movable zone, can it? So this would be yet another special casing. This patch has got it wrong unless I have missed some special casing. -- Michal Hocko SUSE Labs