Re: [PATCH 11/13] dcache: use a dispose list in select_parent

[PATCH 00/12] RFC: shrinker APi rework and generic LRU lists · Dave Chinner <david@fromorbit.com> · 2011-08-23
[PATCH 01/13] fs: Use a common define for inode slab caches · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 01/13] fs: Use a common define for inode slab caches · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 01/13] fs: Use a common define for inode slab caches · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 01/13] fs: Use a common define for inode slab caches · Christoph Hellwig <hch@infradead.org> · 2011-08-24
[PATCH 02/13] dcache: convert dentry_stat.nr_unused to per-cpu counters · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 02/13] dcache: convert dentry_stat.nr_unused to per-cpu counters · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 02/13] dcache: convert dentry_stat.nr_unused to per-cpu counters · Christoph Lameter <hidden> · 2011-08-24
[PATCH 03/13] dentry: move to per-sb LRU locks · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 03/13] dentry: move to per-sb LRU locks · Christoph Hellwig <hch@infradead.org> · 2011-08-24
[PATCH 04/13] mm: new shrinker API · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 04/13] mm: new shrinker API · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 04/13] mm: new shrinker API · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 04/13] mm: new shrinker API · Christoph Hellwig <hch@infradead.org> · 2011-08-24
[PATCH 05/13] mm: convert shrinkers to use new API · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 05/13] mm: convert shrinkers to use new API · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 05/13] mm: convert shrinkers to use new API · Steven Whitehouse <hidden> · 2011-08-23
Re: [PATCH 05/13] mm: convert shrinkers to use new API · Wanlong Gao <hidden> · 2011-08-26
[PATCH 06/13] shrinker: remove old API now it is unused · Dave Chinner <david@fromorbit.com> · 2011-08-23
[PATCH 07/13] Use atomic-long operations instead of looping around cmpxchg(). · Dave Chinner <david@fromorbit.com> · 2011-08-23
[PATCH 08/13] list: add a new LRU list type · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 08/13] list: add a new LRU list type · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 08/13] list: add a new LRU list type · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 08/13] list: add a new LRU list type · Konstantin Khlebnikov <hidden> · 2011-08-23
Re: [PATCH 08/13] list: add a new LRU list type · Christoph Lameter <hidden> · 2011-08-24
[PATCH 09/13] inode: convert inode lru list to generic lru list code. · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 09/13] inode: convert inode lru list to generic lru list code. · Christoph Hellwig <hch@infradead.org> · 2011-08-24
[PATCH 10/13] xfs: convert buftarg LRU to generic code · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 10/13] xfs: convert buftarg LRU to generic code · Christoph Hellwig <hch@infradead.org> · 2011-08-24
[PATCH 11/13] dcache: use a dispose list in select_parent · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 11/13] dcache: use a dispose list in select_parent · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 11/13] dcache: use a dispose list in select_parent · Christoph Hellwig <hch@infradead.org> · 2011-09-05
[PATCH 12/13] dcache: remove dentries from LRU before putting on dispose list · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 12/13] dcache: remove dentries from LRU before putting on dispose list · Christoph Hellwig <hch@infradead.org> · 2011-08-23
Re: [PATCH 12/13] dcache: remove dentries from LRU before putting on dispose list · Dave Chinner <david@fromorbit.com> · 2011-08-23
[PATCH 13/13] dcache: convert to use new lru list infrastructure · Dave Chinner <david@fromorbit.com> · 2011-08-23
Re: [PATCH 13/13] dcache: convert to use new lru list infrastructure · Christoph Hellwig <hch@infradead.org> · 2011-08-24

From: Christoph Hellwig <hch@infradead.org>
Date: 2011-09-05 09:42:52
Also in: linux-fsdevel, lkml

-/**
  * shrink_dcache_sb - shrink dcache for a superblock
  * @sb: superblock
  *

@@ -1073,7 +1054,7 @@ EXPORT_SYMBOL(have_submounts);
  * drop the lock and return early due to latency
  * constraints.
  */
-static long select_parent(struct dentry * parent)
+static long select_parent(struct dentry *parent, struct list_head *dispose)

Btw, the function header comment above select_parent is entirely
incorrect after your changes.

Also I'd suggest folding select_parent into shrink_dcache_parent as
the split doesn't make a whole lot of sense any more.  Maybe factoring
it at a different level would make sense, though.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help