Re: [PATCH 01/13] fs: Use a common define for inode slab caches
From: Dave Chinner <david@fromorbit.com>
Date: 2011-08-23 09:20:41
Also in:
linux-fsdevel, lkml
On Tue, Aug 23, 2011 at 05:13:07AM -0400, Christoph Hellwig wrote:
On Tue, Aug 23, 2011 at 06:56:14PM +1000, Dave Chinner wrote:quoted
From: Dave Chinner <redacted> All inode slab cache initialisation calls need to use specific flags so that certain core functionality works correctly (e.g. reclaimable memory accounting). Some of these flags are used inconsistently across different filesystems, so inode cache slab behaviour can vary according to filesystem type. Wrap all the SLAB_* flags relevant to inode caches up into a single SLAB_INODES flag and convert all the inode caches to use the new flag.Why do we keep the SLAB_HWCACHE_ALIGN flag for some filesystems?
I didn't touch that one, mainly because I think that there are different reasons for wanting cacheline alignment. e.g. a filesystem aimed primarily at embedded systms with slow CPUs and little memory doesn't want to waste memory on cacheline alignment.... Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>