Re: [PATCH RFC v2 46/70] MIPS: kernel: branch: Prevent BGEZL emulation for MIPS R6
From: Maciej W. Rozycki <hidden>
Date: 2015-02-03 11:57:52
On Fri, 16 Jan 2015, Markos Chandras wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/mips/kernel/branch.c b/arch/mips/kernel/branch.c index 502bf2aeb834..b8cc0a2e20a4 100644 --- a/arch/mips/kernel/branch.c +++ b/arch/mips/kernel/branch.c@@ -452,6 +452,11 @@ int __compute_return_epc_for_insn(struct pt_regs *regs, case bgez_op: case bgezl_op: + if (NO_R6EMU && (insn.i_format.rt == bgezl_op)) {
There is no need for parentheses around `==' here, logical operators are well known to have a lower precedence. The same applies throughout this series. Maciej