Re: [Linux-kernel-mentees] [RFC PATCH 17/35] hwmon: (sis5595) Tidy Success/Failure checks
From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-07-14 05:04:08
Also in:
linux-hwmon, linux-pci, lkml
From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-07-14 05:04:08
Also in:
linux-hwmon, linux-pci, lkml
On 7/13/20 5:22 AM, Saheed O. Bolarinwa wrote:
Remove unnecessary check for 0. Signed-off-by: "Saheed O. Bolarinwa" <redacted> --- This patch depends on PATCH 16/35 drivers/hwmon/sis5595.c | 13 ++++--------- drivers/hwmon/via686a.c | 13 ++++--------- drivers/hwmon/vt8231.c | 13 ++++--------- 3 files changed, 12 insertions(+), 27 deletions(-)diff --git a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c index 0ea174fb3048..91fdddaa4136 100644 --- a/drivers/hwmon/sis5595.c +++ b/drivers/hwmon/sis5595.c@@ -825,8 +825,7 @@ static int sis5595_pci_probe(struct pci_dev *dev, pci_write_config_word(dev, SIS5595_BASE_REG, force_addr); } - if (0 != - pci_read_config_word(dev, SIS5595_BASE_REG, &address)) { + if (pci_read_config_word(dev, SIS5595_BASE_REG, &address)) {
Ah, there is is, and I see that others commented on it. Single patch, please. Guenter _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees