Re: [Linux-kernel-mentees] [RFC PATCH 16/35] hwmon: (sis5595) Change PCIBIOS_SUCCESSFUL to 0
From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-07-14 05:02:42
Also in:
linux-hwmon, linux-pci, lkml
On 7/13/20 5:22 AM, Saheed O. Bolarinwa wrote:
quoted hunk ↗ jump to hunk
In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept. Their scope should be limited within arch/x86. Change all PCIBIOS_SUCCESSFUL to 0 Signed-off-by: "Saheed O. Bolarinwa" <redacted> --- drivers/hwmon/sis5595.c | 8 ++++---- drivers/hwmon/via686a.c | 8 ++++---- drivers/hwmon/vt8231.c | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-)diff --git a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c index 0c6741f949f5..0ea174fb3048 100644 --- a/drivers/hwmon/sis5595.c +++ b/drivers/hwmon/sis5595.c@@ -825,7 +825,7 @@ static int sis5595_pci_probe(struct pci_dev *dev, pci_write_config_word(dev, SIS5595_BASE_REG, force_addr); } - if (PCIBIOS_SUCCESSFUL != + if (0 != pci_read_config_word(dev, SIS5595_BASE_REG, &address)) {
Yoda programming already terrible is, but "0 !=" is even worse than that (and completely unnecessary). If you want to clean this up, do it right and drop those unnecessary comparisons. Guenter _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees