Re: [PATCH 12/14] mfd: remove unused mcp-sa11x0/ucb1x00 driver
From: "Arnd Bergmann" <arnd@kernel.org>
Date: 2026-09-09 20:54:08
Also in:
dri-devel, linux-devicetree, linux-hwmon, linux-leds, linux-rtc, linux-watchdog, sashiko-reviews
On Wed, Sep 9, 2026, at 15:48, sashiko-bot@kernel.org wrote:
quoted
The sa1100 platform has been removed, so these drivers are no longer used anywhere.[Severity: High] Is the sa1100 platform fully removed in this series? Looking at the tree, arch/arm/mach-sa1100/assabet.c and arch/arm/mach-sa1100/collie.c still exist and unconditionally include the headers deleted by this patch.
As explained in the cover letter, the platform is only removed in another series I posted.
[Severity: Medium] Does removing the MCP_UCB1200 config symbol leave the collie_battery driver as orphaned dead code? Looking at drivers/power/supply/Kconfig, BATTERY_COLLIE depends on SA1100_COLLIE && MCP_UCB1200. Furthermore, drivers/power/supply/collie_battery.c still includes the now-deleted include/linux/mfd/ucb1x00.h header. If this Kconfig symbol is removed without cleaning up the power supply subsystem, it causes an unmet dependency warning and leaves the battery driver unselectable.
I have separate patches for this.
Arnd