Thread (53 messages) flat view 53 messages, 11 authors, 2d ago

Re: [PATCH 11/14] mfd: remove unused wm8350 driver

From: sashiko-bot@kernel.org
Date: 2026-09-09 13:41:06
Also in: dri-devel, linux-devicetree, linux-hwmon, linux-leds, linux-rtc, linux-watchdog

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale documentation references to the removed wm8350 driver.
--

commit 180d02f3fe78e14ad7acf9b29e2590c4c4ee3a29
Author: Arnd Bergmann [off-list ref]

mfd: remove unused wm8350 driver

This commit removes the wm8350 driver entirely, as it relied on platform
data probing for development boards that have been dropped from the kernel.
It removes the core driver along with its hwmon, gpio, led, power,
regulator, rtc, watchdog, and sound codec components.
mfd: remove unused wm8350 driver

This driver was used on the i.MX31 ADS reference board from Freescale
and the smdk6410 reference board from Samsung. Both used platform_data
based driver probing and are now gone from the kernel.

Since probing with devicetree has never been supported by wm8350,
it is clear that nothing can use the driver on an upstream kernel,
and it is unlikely that anyone is still interested in a devicetree
conversion, so remove it.
[Severity: Low]
Since the wm8350 driver is being completely removed here, should we also
update the documentation files that still reference it as a working example? 

Currently, there are a few places left behind that point developers to the
removed driver code. For instance, in Documentation/scheduler/completion.rst
referencing wait_for_completion_interruptible_timeout:

    why (e.g. see drivers/mfd/wm8350-core.c wm8350_read_auxadc())::

And its Chinese translation in
Documentation/translations/zh_CN/scheduler/completion.rst:

    (例如,见drivers/mfd/wm8350-core.c wm8350_read_auxadc()::

Additionally, Documentation/sound/soc/jack.rst points to the removed codec:

    CODEC integrated jack detection can be see in the WM8350 driver.

Would it make sense to update these documents to point to a different,
active driver as an example to avoid confusing developers who might try
to look up the removed files?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=11
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help