Re: [PATCH 03/14] mfd: remove unused si476x driver
From: sashiko-bot@kernel.org
Date: 2026-09-09 13:38:55
Also in:
dri-devel, linux-devicetree, linux-hwmon, linux-leds, linux-rtc, linux-watchdog
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding 'fsl,imx-audio-si476x' is left orphaned in the fsl-asoc-card.yaml binding document.
--
commit d07c2cc9eb18a826ae9829a06854385c1084b44d
Author: Arnd Bergmann [off-list ref]
mfd: remove unused si476x driver
This commit removes the unused si476x driver, which was originally added
without devicetree support. It drops the MFD core, radio, and ASoC codec
drivers, along with cleaning up the corresponding build rules and the
fsl-asoc-card matching table.
quoted hunk ↗ jump to hunk
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index 310ee4c282a1c..ff8ae6e514ea4 100644 --- a/sound/soc/fsl/fsl-asoc-card.c +++ b/sound/soc/fsl/fsl-asoc-card.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -1398,7 +1391,6 @@ static const struct of_device_id fsl_asoc_card_dt_ids[] = { { .compatible = "fsl,imx-audio-wm8960", .data = &fsl_asoc_wm8960_pdata }, { .compatible = "fsl,imx-audio-mqs", .data = &fsl_asoc_mqs_pdata }, { .compatible = "fsl,imx-audio-wm8524", .data = &fsl_asoc_wm8524_pdata }, - { .compatible = "fsl,imx-audio-si476x", .data = &fsl_asoc_si476x_pdata }, { .compatible = "fsl,imx-audio-wm8958", .data = &fsl_asoc_wm8958_pdata }, { .compatible = "fsl,imx-audio-nau8822", .data = &fsl_asoc_nau8822_pdata }, { .compatible = "fsl,imx-audio-wm8904", .data = &fsl_asoc_wm8904_pdata },
[Severity: Low] Since this patch removes the fsl,imx-audio-si476x compatible string from the fsl_asoc_card_dt_ids matching table, should the devicetree bindings documentation in Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml also be updated to remove the orphaned fsl,imx-audio-si476x entry? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=3