Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete documentation cleanup: left over `_dim` attribute sysfs documentation for the removed ADP5520 driver.
--
commit bc7ed836cc23ed6cd96fb2b01eb1e87798e6abff
Author: Arnd Bergmann [off-list ref]
mfd: remove unused adp5520 driver
This driver requires the use of platform_data definitions rather than
devicetree, but that was last used on the blackfin architecture in
2018 and nothing could have used it upstream since.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/ABI/testing/sysfs-class-backlight b/Documentation/ABI/testing/sysfs-class-backlight
index c453646b06e2c..b73d66942fbbe 100644
--- a/Documentation/ABI/testing/sysfs-class-backlight
+++ b/Documentation/ABI/testing/sysfs-class-backlight
@@ -97,17 +97,6 @@ Description:
The <ambient light zone> is device-driver specific:
- For ADP5520 and ADP5501, <ambient light zone> can be:
-
- =========== ================================================
- Ambient sysfs entry
- light zone
- =========== ================================================
- daylight /sys/class/backlight/<backlight>/daylight_max
- office /sys/class/backlight/<backlight>/office_max
- dark /sys/class/backlight/<backlight>/dark_max
- =========== ================================================
-
For ADP8860, <ambient light zone> can be:
=========== ================================================
[Severity: Low]
Should the corresponding block for the _dim attributes also be removed?
Further down in this file, under the documentation for the _dim attributes,
there is another block describing the sysfs nodes for the ADP5520 driver:
For ADP5520 and ADP5501, <ambient light zone> can be:
=========== ================================================
Ambient sysfs entry
light zone
=========== ================================================
daylight /sys/class/backlight/<backlight>/daylight_dim
office /sys/class/backlight/<backlight>/office_dim
dark /sys/class/backlight/<backlight>/dark_dim
=========== ================================================
Leaving this block behind orphans the documentation for hardware that is no
longer supported.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=5