On Mon, Feb 15, 2021 at 4:33 PM Marek Behun [off-list ref] wrote:
On Mon, 15 Feb 2021 15:00:30 -0800
Roderick Colenbrander [off-list ref] wrote:
quoted
What is the desired naming for these player LEDs? There is not an
officially designed function based on DT bindings. So far they used
"playstation::mac::ledX". When changing the naming scheme towards
"hid" and removing MAC, they would be: "hid%d::led1" etcetera.
Hi,
there is one more thing I forgot to mention in the LED name schema:
devicename:color:function-functionEnumerator
So LED core can for example compose a names in the format:
switch0:green:lan-1
switch0:green:lan-2
switch0:green:lan-3
switch0:green:lan-4
In your case I think the most appropriate name would be something like
hid0:color:indicator-1
hid0:color:indicator-2
...
I am trying to think if indicator is clear enough. Currently devices
use a mixture of names, which is obviously bad (wiimote uses p1-p4 at
the end, sony uses sony1-4 for DualShock 3, hid-nintendo uses
player1-4). I would at least like new drivers to standardize. In
particular in Android frameworks we have a need to map these LEDs back
to the Java InputDevice. Finding the LEDs has been quite painful so
far.
If this is what is decided, I guess we should update the Linux gamepad
document at some point as well.
Are these LEDs of different colors which are impossible to determine?
The string "hid%d::led1" you mention above does not indicate color.
The DualSense LEDs are all white (at least so far?). On controllers
from other brands I have seen them be red or green. So could indeed
use: "hid%d:white".
Marek
Thanks,
Roderick