Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

On Wed, Aug 08, 2012 at 12:40:38PM +0100, Lee Jones wrote:

On Wed, Aug 08, 2012 at 10:49:52AM +0100, Mark Brown wrote:

quoted

quoted

 - MFD adds the IRQ base to the hwirq and registers it as a virq

quoted

Just don't do this step - the only reason to do it is for mapping back
into a linear domain but if you're going to do this...

quoted

quoted

 - AB8500 child devices use *_get_virq() to convert virq to virq - *ERROR*

quoted

...then it's redundant.  The mapping functions in the domain code
replace this functionality.

No, the other way round. This is now required all the time.

Now we force the use of hwirq, the driver needs to convert that into a
virq before requesting the resource. So we need to put *_get_virq()'s into
every child device that requests an IRQ.

Yes, that's exactly what I said - and as a result of doing this the
remapping in the MFD core becomes redundant.