Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
flat view
From: Lee Jones <hidden>
Date: 2012-08-06 15:38:00
Also in:
linux-arm-kernel, lkml
On Mon, Aug 06, 2012 at 01:19:15AM -0700, Dmitry Torokhov wrote:
quoted
- ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); + + ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf; + ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;Why this isn't done inside ab8500_irq_get_virq()?
There's no reason why it can't be. My first version of the patch did just that in fact. Would that be your preference? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html