Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots

On Mon, Aug 06, 2012 at 05:02:26PM +0100, Mark Brown wrote:

On Mon, Aug 06, 2012 at 04:37:52PM +0100, Lee Jones wrote:

quoted

On Mon, Aug 06, 2012 at 01:19:15AM -0700, Dmitry Torokhov wrote:

quoted

quoted

quoted

+	ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf;
+	ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;

quoted

quoted

Why this isn't done inside ab8500_irq_get_virq()?

quoted

There's no reason why it can't be.

quoted

My first version of the patch did just that in fact.

quoted

Would that be your preference?

Restating my comment elsewhere...  why do we even need to do this in
_get_virq() - I'd *really* expect this to be handled by the irq domain
code.

I really should stop reading my emails backwards. :)

I'll look into this tomorrow.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html