Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
From: Mark Brown <hidden>
Date: 2012-08-06 16:02:30
Also in:
linux-arm-kernel, lkml
On Mon, Aug 06, 2012 at 04:37:52PM +0100, Lee Jones wrote:
On Mon, Aug 06, 2012 at 01:19:15AM -0700, Dmitry Torokhov wrote:
quoted
quoted
+ ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf; + ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;
quoted
Why this isn't done inside ab8500_irq_get_virq()?
There's no reason why it can't be.
My first version of the patch did just that in fact.
Would that be your preference?
Restating my comment elsewhere... why do we even need to do this in _get_virq() - I'd *really* expect this to be handled by the irq domain code.