On Wed, May 2, 2012 at 10:45 AM, Jiri Kosina [off-list ref] wrote:

On Wed, 2 May 2012, Benjamin Tissoires wrote:

quoted

quoted

It's currently in a shape I would be okay to pushing out for -next and
scheduling for next merge window, and I will do so tomorrow if nothing
else pops up during testing or reviews.

Hi Jiri,

Well, I'm back in my lab this morning, and I'm testing your branch
against the different devices we have here. I'm observing a strange
problem: when connecting some devices, the first touch is always at
0,0. If I rmmod and insmod hid_multitouch it seems to work after....

I'm investigating this bug now. I'll tell you when I'm done. I still
don't now if it's related to Henrik's changes or 3.4-rc4.

I see, thanks a lot for the heads-up, I will be waiting for your analysis
of this.

I have already renamed the branch to 'device-groups' and merged it into
branch that goes into next, so please send me any followup patches on top
of that queue now.

Ok, I think I understood: nothing related to Henrik's changes. The bug
is also present in the upstream kernel.
In the function set_last_slot_field, I was doing a:
test_bit(usage->hid, hi->input->absbit);

for instance, 0x10030 (X hid field) in the absbit bit field which
contains only ABS_CNT (0x40) bits.... That's why it was a random bug.
Now I understood why Ubuntu complained about this test ;-)

I won't have the time to submit the patch right now, I have to give a
lecture this afternoon. Maybe this evening or tomorrow.

Cheers,
Benjamin

Thanks,

--
Jiri Kosina
SUSE Labs