Re: [PATCH v3 5/6] hid-multitouch: Switch to device groups
From: Henrik Rydberg <hidden>
Date: 2012-04-30 18:26:04
Also in:
lkml
Subsystem:
hid core layer, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds
I remarked a small regression in this patch: the detection of the serial protocol is not handled anymore. I was indeed relying on the fact that the parameter "id" in mt_probe was null to know that the device was not already in the list of known devices.
I see. Will this suffice?
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 125c1e7..507981e 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c@@ -673,8 +673,8 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id) if (ret) goto fail; - if (!id && td->touches_by_report == 1) { - /* the device has been sent by hid-generic */ + /* unknown serial devices need special quirks */ + if ((!id || id->product == HID_ANY_ID) && td->touches_by_report == 1) { mtclass = &td->mtclass; mtclass->quirks |= MT_QUIRK_ALWAYS_VALID; mtclass->quirks &= ~MT_QUIRK_NOT_SEEN_MEANS_UP;
Cheers, Henrik