Thread (28 messages) 28 messages, 5 authors, 2012-01-17

Re: [PATCH v3] bcm5974: Set BUTTONPAD property

From: Chase Douglas <hidden>
Date: 2012-01-11 09:23:49

On 01/11/2012 08:38 AM, Dmitry Torokhov wrote:
On Tue, Jan 10, 2012 at 12:42:12PM +0100, Henrik Rydberg wrote:
quoted
On Tue, Jan 10, 2012 at 12:56:49PM +0200, Jussi Pakkanen wrote:
quoted
Some bcm5974 trackpads have a physical button beneath the physical surface.
This patch sets the property bit so user space applications can
detect the trackpad type and act accordingly.

Signed-off-by: Jussi Pakkanen <redacted>
Cc: stable@vger.kernel.org
Applied, however I removed stable notation as this change IMO does not
qualify for the stable since it does not address a regression.
It's not a regression per-se, but we want to fix buttonpad support, and
we can't do that without this patch. It's a clear bug that when the
property was added we did not set the property in the devices that need it.

I believe this is exactly what the stable queue is for. Are you saying
you will still NACK this patch if we submit it to the stable queue?
Otherwise, we'll have to distro-patch it for our next Ubuntu release.

I wish you had asked about this before committing it to your tree
without the stable Cc. If we convince you that it makes sense for
stable, we now have quite a bit more work to do to get it into stable...

-- Chase
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help