Re: [PATCH] Set buttonpad property on those bcm5974 devices that have a physical button.
From: Henrik Rydberg <hidden>
Date: 2012-01-10 09:45:18
Jussi, On Tue, Jan 10, 2012 at 11:36:04AM +0200, Jussi Pakkanen wrote:
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/bcm5974.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index 5ec617e..df3fd85 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c@@ -876,6 +876,9 @@ static int bcm5974_probe(struct usb_interface *iface, input_dev->name = "bcm5974"; input_dev->phys = dev->phys; + if (bcm5974_get_config(dev->udev)->caps & HAS_INTEGRATED_BUTTON) { + __set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit); + } usb_to_input_id(dev->udev, &input_dev->id); /* report driver capabilities via the version field */ input_dev->id.version = cfg->caps;-- 1.7.5.4
Besides being put in the wrong place, the already-defined local variable is not used. Any particular reason for it? Otherwise, please bundle the change with the rest in setup_events_to_report(). Thanks, Henrik