Re: [PATCH v2] Set buttonpad property on those bcm5974 devices that have a physical button.
From: Henrik Rydberg <hidden>
Date: 2012-01-10 10:22:11
On Tue, Jan 10, 2012 at 12:08:30PM +0200, Jussi Pakkanen wrote:
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/bcm5974.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index 5ec617e..88fabfb 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c@@ -434,6 +434,10 @@ static void setup_events_to_report(struct input_dev *input_dev, __set_bit(BTN_LEFT, input_dev->keybit); input_set_events_per_packet(input_dev, 60); + + if (cfg->caps & HAS_INTEGRATED_BUTTON) { + __set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit); + } } /* report button data as logical button state */-- 1.7.5.4
Please move the lines above input_set_events_per_packet(), since that function may depend on the device properties in the future. Also, please remove the braces. The subject does not say why the change is made, and you are also missing the signed-off-by line. Please run checkpatch before submitting. Henrik