Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys

From
Mark Brown <hidden>
Date
2011-07-26 08:54:38
Reply to
Greg KH, 2011-07-25
On Mon, Jul 25, 2011 at 04:25:33PM -0700, Greg KH wrote:
On Mon, Jul 25, 2011 at 07:26:28PM +0100, Mark Brown wrote:
quoted
They're asking if drivers should set driver_data to NULL while
unbinding, which always struck me as a waste of time given that
nothing except a currently bound driver should be using driver_data.
Yeah, it's not needed, as nothing should rely on that.  However it's
also not hurting anything either.
Every time I see it it always sets off a red flag, partly because we
shouldn't need to bother at all and partly because to the extent it's
valuable it's not something we should be doing on a driver by driver or
even subsystem by subsystem basis.
Thread (19 messages) 19 messages, 5 authors, last reply 2011-07-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help