Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys

From
Wanlong Gao <hidden>
Date
2011-07-26 06:26:47
Reply to
Greg KH, 2011-07-26
On 07/26/2011 02:02 PM, Greg KH wrote:
On Tue, Jul 26, 2011 at 01:36:00PM +0800, Wanlong Gao wrote:
quoted
On 07/26/2011 12:39 PM, Greg KH wrote:
quoted
quoted
+
+	if (drv->remove) {
+		dev_dbg(_dev, "remove\n");
+		status = drv->remove(dev);
+	} else {
+		status = 0;
+	}
Again, why would remove ever be NULL?

This whole thing isn't needed at all.

greg k-h
Yeah, I see.

But Greg, why does i2c-core do this?
like:drivers/i2c/i2c-core.c:
The i2c core has different requirements than the driver core does,
right?  They are two totally different things, please don't assume that
the rules for one are the same for the other.

greg k-h
Hmm...They are totally different things, maybe I see..


-- 
Thanks
Best Regards
Wanlong Gao
Thread (19 messages) 19 messages, 5 authors, last reply 2011-07-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help