Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys

On Mon, Jul 25, 2011 at 11:34:29PM +0800, Wanlong Gao wrote:

quoted

quoted

On 07/25/2011 04:30 PM, Dmitry Torokhov wrote:

quoted

I'd rather have platform devices core clean up this pointer, then we
could stop caring about it in all drivers...

then I said:

quoted

But the platform devices core just call the method of each own.
And don't care about the details like pdata, etc.

Meanwhile, I think the platform core need not care about these
details.

and Greg, what do you think about this?

this is the thread, Greg, understand now?

For short, it's all about the platform driver data. Since many drivers
set the platform driver data to NULL when it is removed, then Dmitry
think it should be done in the platform driver core instead.

Right, like i2c bus we could just have platform core clean up platform
drvdata pointer after calling ->remove() and also if ->probe() errors
out.

Then individual drivers do not have to care about cleaning up this
pointer.

Thanks.

-- 
Dmitry