Re: [PATCH] drivers:input:set driver data to NULL for pcap_keys

On Mon, Jul 25, 2011 at 07:26:28PM +0100, Mark Brown wrote:

On Mon, Jul 25, 2011 at 08:21:06AM -0700, Greg KH wrote:

quoted

On Mon, Jul 25, 2011 at 05:14:11PM +0800, Wanlong Gao wrote:

quoted

On 07/25/2011 04:30 PM, Dmitry Torokhov wrote:

quoted

quoted

quoted

I'd rather have platform devices core clean up this pointer, then we
could stop caring about it in all drivers...

quoted

quoted

But the platform devices core just call the method of each own.
And don't care about the details like pdata, etc.

quoted

quoted

Meanwhile, I think the platform core need not care about these details.

quoted

quoted

and Greg, what do you think about this?

quoted

I don't understand what you are asking me.

They're asking if drivers should set driver_data to NULL while
unbinding, which always struck me as a waste of time given that
nothing except a currently bound driver should be using driver_data.

Yeah, it's not needed, as nothing should rely on that.  However it's
also not hurting anything either.

greg k-h