On Tue, Sep 22, 2009 at 08:53:19AM +0100, Hennerich, Michael wrote:

quoted

From: Jiri Kosina
Sent: Tuesday, September 22, 2009 9:33 AM

On Mon, 21 Sep 2009, Dmitry Torokhov wrote:

quoted

quoted

+	if (event & KP_INT) {
+		adp5520_read(dev->master, KP_INT_STAT_1, &reg_val_low);
+		adp5520_read(dev->master, KP_INT_STAT_2, &reg_val_high);
+
+		keymask = (reg_val_high << 8) | reg_val_low;
+		/* Read twice to clear */
+		adp5520_read(dev->master, KP_INT_STAT_1, &reg_val_low);
+		adp5520_read(dev->master, KP_INT_STAT_2, &reg_val_high);
+		keymask |= (reg_val_high << 8) | reg_val_low;
+		adp5520_keys_report_event(dev, keymask, 1);
+	}
+
+	if (event & KR_INT) {

Why do you check the same condition twice?

It actually doesn't seem to be the same condition (KP_INT vs. KR_INT), but
it's difficult to say, as these constants are apparently added in some
other patch I have no idea about.

KP Key-Press versus Key-Release 

Yeah, my bad... However the constants could be made more distinct.

-- 
Dmitry