Re: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs
From: Mike Frysinger <hidden>
Date: 2009-09-21 13:47:59
Also in:
lkml
On Mon, Sep 21, 2009 at 00:04, Andrew Morton wrote:
On Sun, 20 Sep 2009 18:40:41 -0400 Mike Frysinger wrote:quoted
On Sun, Sep 20, 2009 at 02:30, Andrew Morton wrote:quoted
On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger wrote:quoted
+struct adp5520_keys { + __ __ struct input_dev *input; + __ __ struct notifier_block notifier; + __ __ struct device *master; + __ __ unsigned short keycode[ADP5520_KEYMAPSIZE];Where is ADP5520_KEYMAPSIZE defined?all these things are in the common mfd adp5520 patch. it introduces a common adp5520 header.err, what common MFD patch? There was nothing in either the changelog nor the patch title which indicated that this patch had a dependency on other patches. This makes things harder for mergers and reviewers, especially when the patchset hits multiple subsystems, maintained by multiple developers. Probably the best way to handle this sort of thing is to present it as a sequence-numbered patch series with well-chosen cc's and an overall description of the dependencies and perhaps the merge plan in [patch 0/n].
the MFD patch has been sent to the MFD guy already for review. being an MFD means it touches like 4 or 5 different subsystems. but the only dependency is on the MFD core. -mike _______________________________________________ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel