Thread (14 messages) 14 messages, 6 authors, 2009-09-23

Re: [PATCH] input/keyboard: new driver for ADP5520 MFD PMICs

From: Andrew Morton <hidden>
Date: 2009-09-20 06:32:41
Also in: lkml

On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger [off-list ref] wrote:
...
+struct adp5520_keys {
+	struct input_dev *input;
+	struct notifier_block notifier;
+	struct device *master;
+	unsigned short keycode[ADP5520_KEYMAPSIZE];
Where is ADP5520_KEYMAPSIZE defined?

I can find a single instance in the tree:

./arch/blackfin/mach-bf537/boards/stamp.c:static const unsigned short adp5520_keymap[ADP5520_KEYMAPSIZE] = {
	
is it runtime-generated or something?
+};
+
+static void adp5520_keys_report_event(struct adp5520_keys *dev,
+					unsigned short keymask, int value)
+{
+	int i;
+
+	for (i = 0; i < ADP5520_MAXKEYS; i++)
Where is ADP5520_MAXKEYS defined?
+		if (keymask & (1 << i))
+			input_report_key(dev->input, dev->keycode[i], value);
It seems odd that keycode is dimensioned with ADP5520_KEYMAPSIZE but
here we iterate up to ADP5520_MAXKEYS.
+
+	input_sync(dev->input);
+}
+
...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help