On Mon, 21 Sep 2009 09:40:46 -0400 Mike Frysinger [off-list ref] wrote:

On Mon, Sep 21, 2009 at 00:04, Andrew Morton wrote:

quoted

On Sun, 20 Sep 2009 18:40:41 -0400 Mike Frysinger wrote:

quoted

On Sun, Sep 20, 2009 at 02:30, Andrew Morton wrote:

quoted

On Thu, 17 Sep 2009 14:24:10 -0400 Mike Frysinger wrote:

quoted

+struct adp5520_keys {
+ __ __ struct input_dev *input;
+ __ __ struct notifier_block notifier;
+ __ __ struct device *master;
+ __ __ unsigned short keycode[ADP5520_KEYMAPSIZE];

Where is ADP5520_KEYMAPSIZE defined?

all these things are in the common mfd adp5520 patch. __it introduces a
common adp5520 header.

err, what common MFD patch? __There was nothing in either the changelog
nor the patch title which indicated that this patch had a dependency on
other patches. __This makes things harder for mergers and reviewers,
especially when the patchset hits multiple subsystems, maintained by
multiple developers.

Probably the best way to handle this sort of thing is to present it as a
sequence-numbered patch series with well-chosen cc's and an overall
description of the dependencies and perhaps the merge plan in [patch
0/n].

the MFD patch has been sent to the MFD guy already for review.  being
an MFD means it touches like 4 or 5 different subsystems.  but the
only dependency is on the MFD core.

What you said has nothing to do with what I said.

As the patch was presented, Dmitry or I could well have merged it only
to find out that it doesn't compile.