Thread (12 messages) 12 messages, 3 authors, 2026-01-08

Re: [PATCH 3/5] arm64: dts: qcom: msm8953-xiaomi-vince: correct wled ovp value

From: Konrad Dybcio <hidden>
Date: 2026-01-07 14:08:10
Also in: dri-devel, linux-arm-msm, linux-devicetree, linux-leds, lkml

On 1/7/26 2:31 PM, Barnabás Czémán wrote:
Correct wled ovp value from 29600 to 29500.
This tells us what the fix is, but not why the fix needs to be made.
We can infer the former from the patch contents, but it's really
important that the next reader, perhaps in 5 years, can find out the
reason it was made.

How about:

"""
PMI8950 doesn't actually support setting an OVP threshold value of
29.6 V. The closest allowed value is 29.5 V. Set that instead.
"""

With this or similar commit message:

Reviewed-by: Konrad Dybcio <redacted>

Konrad
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help