Re: [PATCH 2/5] backlight: qcom-wled: Support ovp values for PMI8950

From
Konrad Dybcio <hidden>
Date
2026-01-07 14:05:41
Also in
dri-devel, linux-arm-msm, linux-devicetree, linux-leds, lkml
Reply to
Barnabás Czémán, 2026-01-07
On 1/7/26 2:31 PM, Barnabás Czémán wrote:
WLED4 found in PMI8950 supports different ovp values.

Fixes: 10258bf4534bf ("backlight: qcom-wled: Add PMI8950 compatible")
Signed-off-by: Barnabás Czémán <redacted>
---
[...]
quoted hunk ↗ jump to hunk
 	case 4:
-		u32_opts = wled4_opts;
-		size = ARRAY_SIZE(wled4_opts);
+		if (of_device_is_compatible(dev->of_node, "qcom,pmi8950-wled")) {
+			u32_opts = pmi8950_wled4_opts;
+			size = ARRAY_SIZE(pmi8950_wled4_opts);
+		} else {
+			u32_opts = wled4_opts;
+			size = ARRAY_SIZE(wled4_opts);
+		}
I really don't like how this driver went about abstracting parsing
all of that, but that's not your fault

Reviewed-by: Konrad Dybcio <redacted>

Konrad
Thread (12 messages) 12 messages, 3 authors, last reply 2026-01-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help